feat: Ensure SBAccessPolicy verifies the user owns the sandbox#407
Merged
chrisburr merged 4 commits intoDIRACGrid:mainfrom Mar 27, 2025
Merged
feat: Ensure SBAccessPolicy verifies the user owns the sandbox#407chrisburr merged 4 commits intoDIRACGrid:mainfrom
chrisburr merged 4 commits intoDIRACGrid:mainfrom
Conversation
natthan-pigoux
force-pushed
the
feat_sb_dl_permissions
branch
2 times, most recently
from
2fd8647 to
d23d723
Compare
natthan-pigoux
force-pushed
the
feat_sb_dl_permissions
branch
from
d23d723 to
183aa2d
Compare
Contributor
Author
|
Not sure about the integration test failure. Should I regenerate the client? |
Contributor
This test was broken independently of you. I just restarted it. |
Contributor
and it works OK now. |
natthan-pigoux
force-pushed
the
feat_sb_dl_permissions
branch
from
d4ef27e to
dde7d06
Compare
Contributor
Author
Thanks @fstagni, I fixed the remaining failing test. |
chrisburr
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #13 : "Implement sandbox permissions for downloading"